fix(native-filters): prevent circular dependencies and improve dependency handling #35317
+57
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
dashboard:native-filters
![korbit-ai[bot]](https://avatars.githubusercontent.com/in/322216?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review by Korbit AI
Korbit automatically attempts to detect when you fix issues in new commits.
| Category | Issue | Status |
|---|---|---|
 |
Inefficient circular dependency checking ▹ view | 🧠 Not in standard |
|
Unnecessary array copying in dependency map ▹ view | 🧠 Not in scope |
|
Overly broad useMemo dependencies ▹ view | 🧠 Incorrect |
 |
Inconsistent dependency UI state ▹ view | 🧠 Incorrect |
Files scanned
| File Path | Reviewed |
|---|---|
| superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FiltersConfigForm/DependencyList.tsx | ✅ |
| superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FiltersConfigModal.tsx | ✅ |
| superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FiltersConfigForm/FiltersConfigForm.tsx | ✅ |
Explore our documentation to understand the languages and file types we support and the files we ignore.
Check out our docs on how you can make Korbit work best for you and your team.
Comment on lines
+587
to
+590
| const availableFilters = useMemo( | ||
| () => getAvailableFilters(filterId), | ||
| [getAvailableFilters, filterId, filters], | ||
| ); |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Comment on lines
923
to
+925
| {canDependOnOtherFilters && | ||
| hasAvailableFilters && ( | ||
| (hasAvailableFilters || | ||
| dependencies.length > 0) && ( |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Comment on lines
+369
to
+379
| Object.keys(filters).forEach(key => { | ||
| const formItem = filters[key]; | ||
| const configItem = filterConfigMap[key]; | ||
| let array: string[] = []; | ||
| if (formItem && 'dependencies' in formItem) { | ||
| array = [...formItem.dependencies]; | ||
| } else if (configItem?.cascadeParentIds) { | ||
| array = [...configItem.cascadeParentIds]; | ||
| } | ||
| dependencyMap.set(key, array); | ||
| }); |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Comment on lines
+388
to
+390
| const testDependencies = [...currentDependencies, id]; | ||
| const testMap = new Map(dependencyMap); | ||
| testMap.set(filterId, testDependencies); |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
This PR fixes circular dependency issues in dashboard native filters and improves dependency handling. The changes include:
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION