Skip to content

Conversation

andreachild
Copy link
Contributor

…nly traversers that have been through the most loops.

…nly traversers that have been through the most loops.
@codecov-commenter
Copy link

codecov-commenter commented Sep 26, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (global-repeat-poc@0b6a37f). Learn more about missing BASE report.

Additional details and impacted files
@@                 Coverage Diff                  @@
##             global-repeat-poc    #3217   +/-   ##
====================================================
  Coverage                     ?   76.76%           
  Complexity                   ?    14904           
====================================================
  Files                        ?     1157           
  Lines                        ?    72391           
  Branches                     ?     8018           
====================================================
  Hits                         ?    55572           
  Misses                       ?    13819           
  Partials                     ?     3000           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Override
public Set<TraverserRequirement> getRequirements() {
return this.getSelfAndChildRequirements(TraverserRequirement.BULK);
return this.getSelfAndChildRequirements(TraverserRequirement.BULK, TraverserRequirement.NESTED_LOOP);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: I don't think it's necessary to add a nested loop requirement to this step, as in theory the only time this will be needed is if its inside a nested repeat step, in which case RepeatStep itself will already be providing the nested loop requirement. A similar argument would apply to any other steps which may be given "loop awareness" such as RangeGlobalStep. Note how even LoopsStep does not explicitly set a single loop or nested loop requirement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants