Skip to content

Conversation

kirill-stepanishin
Copy link
Contributor

@kirill-stepanishin kirill-stepanishin commented Oct 3, 2025

Summary

Integrates Python Gremlin examples into CI to ensure they remain functional in future releases. Examples now execute automatically after integration tests and fail the build if broken.

Changes Made

  • Added example execution to gremlin-python-integration-tests container in docker-compose.yml
  • Made server URLs configurable via environment variables (replaces hardcoded localhost:8182)
  • Added configurable vertex labels and targeted cleanup using has_label()
  • Added graph binding detection - uses gmodern in CI, g locally for proper environment handling

@codecov-commenter
Copy link

codecov-commenter commented Oct 3, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 76.24%. Comparing base (9b46b67) to head (7c3bc33).
⚠️ Report is 387 commits behind head on 3.7-dev.

Additional details and impacted files
@@              Coverage Diff              @@
##             3.7-dev    #3231      +/-   ##
=============================================
+ Coverage      76.14%   76.24%   +0.09%     
- Complexity     13152    13305     +153     
=============================================
  Files           1084     1092       +8     
  Lines          65160    67657    +2497     
  Branches        7285     7378      +93     
=============================================
+ Hits           49616    51582    +1966     
- Misses         12839    13330     +491     
- Partials        2705     2745      +40     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@kirill-stepanishin kirill-stepanishin marked this pull request as ready for review October 3, 2025 21:38
@kirill-stepanishin kirill-stepanishin force-pushed the python-examples-integration branch from 6729d40 to e7f3287 Compare October 10, 2025 21:47
- Add examples execution to gremlin-python-integration-tests container
- Make server URLs configurable via environment variables
- Add cleanup for mutating examples
- Graph binding detection (gmodern in CI, g locally)
- Handle SSL certificates and Kerberos failures
- Build fails if any example fails to execute
- Add explanatory comments for Docker port configurations
- Use specialized labels (person-py-ex, py-conn-ex) to isolate test data
- Replace global cleanup with targeted cleanup using has_label()
- Add conditional SSL certificate verification for non-localhost connections
- Fix Kerberos hostname to match conftest.py approach
@kirill-stepanishin kirill-stepanishin force-pushed the python-examples-integration branch from 048955a to 523ac1b Compare October 14, 2025 15:55
@andreachild
Copy link
Contributor

VOTE +1 thanks!

@Cole-Greer
Copy link
Contributor

VOTE +1

1 similar comment
@kenhuuu
Copy link
Contributor

kenhuuu commented Oct 15, 2025

VOTE +1

@andreachild
Copy link
Contributor

Hoping to merge this today, I also forgot to ask for a changelog entry

@kirill-stepanishin
Copy link
Contributor Author

Hoping to merge this today, I also forgot to ask for a changelog entry

Added a generic changelog entry for all GLV examples in 7c3bc33

@andreachild
Copy link
Contributor

Unfortunately I need to ask you to make a separate PR to target these same changes but against master branch. It seems there are a few non-trivial changes that are needed to get the dev-level examples to work against master code. Once the master PR is approved I will merge both together.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants