Skip to content

Conversation

leon-inf
Copy link
Contributor

No description provided.

@leon-inf leon-inf added this to the Release 1.1.0 milestone Oct 14, 2025
@leon-inf leon-inf requested a review from a team as a code owner October 14, 2025 02:52
@apecloud-bot
Copy link
Collaborator

Auto Cherry-pick Instructions

Usage:
  - /nopick: Not auto cherry-pick when PR merged.
  - /pick: release-x.x [release-x.x]: Auto cherry-pick to the specified branch when PR merged.

Example:
  - /nopick
  - /pick release-1.0

@github-actions github-actions bot added the size/L Denotes a PR that changes 100-499 lines. label Oct 14, 2025
@leon-inf
Copy link
Contributor Author

/pick release-1.0

@apecloud-bot apecloud-bot added the pick-1.0 Auto cherry-pick to release-1.0 when PR merged label Oct 14, 2025
@leon-inf leon-inf force-pushed the support/rolling-update-one-replica branch from c4415cd to 6a7848e Compare October 14, 2025 03:29
@codecov
Copy link

codecov bot commented Oct 14, 2025

Codecov Report

❌ Patch coverage is 40.74074% with 32 lines in your changes missing coverage. Please review.
✅ Project coverage is 59.76%. Comparing base (4de60f2) to head (6a7848e).
⚠️ Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
pkg/controller/instanceset/reconciler_update.go 40.74% 23 Missing and 9 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9807      +/-   ##
==========================================
+ Coverage   59.57%   59.76%   +0.19%     
==========================================
  Files         551      551              
  Lines       59765    60008     +243     
==========================================
+ Hits        35607    35866     +259     
+ Misses      20912    20901      -11     
+ Partials     3246     3241       -5     
Flag Coverage Δ
unittests 59.76% <40.74%> (+0.19%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@apecloud-bot apecloud-bot added the approved PR Approved Test label Oct 15, 2025
@leon-inf
Copy link
Contributor Author

/approve

@leon-inf leon-inf merged commit c620878 into main Oct 15, 2025
41 checks passed
@leon-inf leon-inf deleted the support/rolling-update-one-replica branch October 15, 2025 07:39
@apecloud-bot
Copy link
Collaborator

/cherry-pick release-1.0

@apecloud-bot
Copy link
Collaborator

🤖 says: Error cherry-picking.

Auto-merging controllers/workloads/instanceset_controller_test.go
CONFLICT (content): Merge conflict in controllers/workloads/instanceset_controller_test.go
Auto-merging pkg/controller/instanceset/reconciler_update.go
error: could not apply c620878... chore: fix to update one pod in a rolling update at a time (#9807)
hint: After resolving the conflicts, mark them with
hint: "git add/rm ", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".
hint: Disable this message with "git config set advice.mergeConflict false"

@apecloud-bot
Copy link
Collaborator

🤖 says: ‼️ cherry pick action failed.
See: https://github.com/apecloud/kubeblocks/actions/runs/18521501218

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved PR Approved Test pick-1.0 Auto cherry-pick to release-1.0 when PR merged size/L Denotes a PR that changes 100-499 lines.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants