-
Notifications
You must be signed in to change notification settings - Fork 131
docs: Sub-schemas in input-schema #1992
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Preview for this PR was built for commit |
Preview for this PR was built for commit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Haven't gone too deep reviewing it. Just checked if the location of the docs and the text themselves make sense to me.
One comment is that maybe we should restructure the whole input schema doc in later PR. It's too large now. We could maybe have a general page and then one page for each type of input?
Good idea, also I would put the available fields for each type at the top of the type-specific section, and the example below. Currently you need to scroll down through all the examples to see the actual table with fields. |
Yeah I concur this is getting a little bit unwieldy. Unfortunately with curren workload I have very little capacity to try and address it until December. But I'm not sure about that approach that would be adding a lot of additional pages, let me try to think how to best approach it from information architecture POV |
Document sub-schema support in input-schema specification page in docs.