Skip to content

Conversation

@Mantisus
Copy link
Collaborator

@Mantisus Mantisus commented Dec 6, 2025

Description

  • Ensures that core Request fields such as unique_key, method, and others will not be changed.

@Mantisus Mantisus requested a review from vdusek December 6, 2025 22:01
@Mantisus Mantisus self-assigned this Dec 6, 2025
@vdusek vdusek requested review from Pijukatel and janbuchar December 8, 2025 08:27
Copy link
Collaborator

@vdusek vdusek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree in principle, but I'm not entirely sure we can do it. We should definitely test this change on the platform - run integration and E2E tests in the SDK.

@janbuchar
Copy link
Collaborator

janbuchar commented Dec 8, 2025

I agree in principle, but I'm not entirely sure we can do it. We should definitely test this change on the platform - run integration and E2E tests in the SDK.

I completely agree with this. I don't see a good reason why it shouldn't work, but better safe than sorry.

Once this is ready, no need to wait for my review unless you decide to change the PR substantially.

@janbuchar janbuchar removed their request for review December 8, 2025 08:56
@Pijukatel
Copy link
Collaborator

I can not start the E2E tests directly on the branch from forked repo. I created a copy of the branch and started the tests here: https://github.com/apify/crawlee-python/actions/runs/20028369926

@vdusek
Copy link
Collaborator

vdusek commented Dec 8, 2025

@vdusek
Copy link
Collaborator

vdusek commented Dec 8, 2025

Also do we want to freeze only these 4 fields?

List of all from docs:

image

What about label, max_retries, no_retry, enqueue_strategy, forefront?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants