Add split copy #2563
Open
Add split copy #2563
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @YifanShenSZ |
metascroy
force-pushed
the
add-split-copy
branch
from
2b1df19 to
35edb4d
Compare
|
Thanks @metascroy for the pull request. Can you add a unit test? |
|
CI failed, but looks like due to torch 2.8 breaking changes |
|
@metascroy please rebase on top of latest main then let's try CI again |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds coremltools support for split_copy, the copy variant of split. Many view ops in coremltools already register the copy variant as an alias, e.g.,
view: https://github.com/apple/coremltools/blob/main/coremltools/converters/mil/frontend/torch/ops.py#L2316
permute: https://github.com/apple/coremltools/blob/main/coremltools/converters/mil/frontend/torch/ops.py#L1011
But it looks like for split this was missed.
Similar PR for transpose_copy: #2556