Skip to content

Cthielen/cherry pick cmake fix #497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 4 commits into from
Closed

Cthielen/cherry pick cmake fix #497

wants to merge 4 commits into from

Conversation

@cthielen
Copy link
Contributor

@cthielen cthielen commented Jul 25, 2025

This PR cherry picks https://github.com/apple/swift-collections/pull/482/commits, which fixes a typo in the CMake build that is blocking swiftlang/swift#83310.

Checklist

  • I've read the Contribution Guidelines
  • My contributions are licensed under the Swift license.
  • I've followed the coding style of the rest of the project.
  • I've added tests covering all new code paths my change adds to the project (if appropriate).
  • I've added benchmarks covering new functionality (if appropriate).
  • I've verified that my change does not break any existing tests or introduce unexplained benchmark regressions.
  • I've updated the documentation if necessary.

cthielen and others added 4 commits July 23, 2025 14:38
@cthielen
Include DequeModule in the Foundation toolchain build
ab46d64
@lorentey
Merge pull request apple#496 from cthielen/release/1.2
8c0c0a8 
Include DequeModule in the Foundation toolchain build
@etcwilde @cthielen
CMake: Remove duplicate platform info includes
4cf344d 
It looks like something was merged in a funny way resulting in the
platform info module being included twice in the top-level CMakeLists
files. Removing one of them.
@etcwilde @cthielen
CMake: Fix typo
31183bf 
Misspelled Swift in the Platform info compiler target check.
Fixing that.
@cthielen cthielen closed this Jul 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lorentey lorentey Awaiting requested review from lorentey lorentey will be requested when the pull request is marked ready for review lorentey is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@cthielen @lorentey @etcwilde