feat: replaced pink 1 with pink2 in documents permission component #2128
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ItzNotABug
requested changes
Jul 17, 2025
ItzNotABug
requested changes
Jul 18, 2025
| @@ -343,7 +344,8 @@ | |||
| {/each} | |||
| </Table.Root> | |||
| <div class="u-flex u-flex-vertical u-gap-16"> | |||
There was a problem hiding this comment.
Lets use the Layout.Stack here.
| source: 'function_keys_card', | ||
| destination: 'docs' | ||
| })} | ||
| <div class="u-margin-block-start-24"> |
There was a problem hiding this comment.
why do we need this margin here?
...tes/(console)/project-[region]-[project]/functions/function-[function]/settings/+page.svelte
Outdated
Show resolved
Hide resolved
...tes/(console)/project-[region]-[project]/functions/function-[function]/settings/+page.svelte
Outdated
Show resolved
Hide resolved
...onsole)/project-[region]-[project]/storage/bucket-[bucket]/settings/updateMaxFileSize.svelte
Outdated
Show resolved
Hide resolved
ItzNotABug
requested changes
Jul 24, 2025
| @@ -342,15 +344,16 @@ | |||
| </Table.Row.Base> | |||
| {/each} | |||
| </Table.Root> | |||
| <div class="u-flex u-flex-vertical u-gap-16"> | |||
| <Alert>To change the selection edit the relationship settings.</Alert> | |||
| <Layout.Stack gap="m" direction="column"> | |||
There was a problem hiding this comment.
gap="m" is 12px, doesn't seem the same from before.
ItzNotABug
approved these changes
Jul 25, 2025
HarshMN2345
deleted the
feat-SER-16-replace-pink1-with-pink2-doc-permissions
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Replaced pink 1 with pink 2 alert component n documents permission component
Test Plan
Related PRs and Issues
(If this PR is related to any other PR or resolves any issue or related to any issue link all related PR and issues here.)
Have you read the Contributing Guidelines on issues?
yes