fix: Enable Update button for any field change in all OAuth provider … #2148
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stnguyen90
previously requested changes
Jul 23, 2025
src/routes/(console)/project-[region]-[project]/auth/(providers)/gitlabOAuth.svelte
Show resolved
Hide resolved
src/routes/(console)/project-[region]-[project]/auth/(providers)/oidcOAuth.svelte
Outdated
Show resolved
Hide resolved
ItzNotABug
approved these changes
Jul 28, 2025
ItzNotABug
approved these changes
Aug 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Updates all OAuth provider modals so the "Update" button is enabled as long as any change is made, regardless of which fields are filled.
Ensures the UI matches the "optional" label and backend/API behavior for all OAuth providers.
Improves user experience by removing unnecessary required-field enforcement in the UI.
Keeps the "Enabled" toggle as a control for activating or deactivating the provider for authentication, but does not restrict editing of other fields.
UI changes for Microsoft and Okta modals
Microsoft: Ensures the modal title always displays correctly and matches the style of other provider modals.
Okta: Adds a proper modal title and sets the modal width to be consistent with other OAuth modals.
Test Plan
Related PRs and Issues
(If this PR is related to any other PR or resolves any issue or related to any issue link all related PR and issues here.)
Have you read the Contributing Guidelines on issues?
yes