Update to tree sitter 15 - and fix some more syntax #17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR updates the Move tree-sitter grammar to version 15, adds support for new syntax patterns (compound assignment operators, updated cast and visibility syntax, type parameter definitions, etc.), and refreshes the test corpora to exercise those grammar changes.
- Extend grammar.json and grammar.js with compound assignment operators (+=, -=, etc.), parenthesis-free
ascasts, and newvisibilityand type parameter rules. - Update
tree-sitter.jsonto point at the new schema and enable additional language bindings. - Add and refresh Move test corpus files to cover the updated syntax patterns.
Reviewed Changes
Copilot reviewed 12 out of 14 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tree-sitter.json | bumped schema URL and updated metadata/bindings |
| test/corpus/test_script.move | new Move script testing arithmetic, option and vector syntax |
| test/corpus/test_module_split_address.move | added test for legacy module/address split syntax |
| test/corpus/test_module_no_addr.move | added test for module without top‐level address syntax |
| test/corpus/test_module.move | large Move module exercising updated grammar |
| test/corpus/short.move | smaller Move module testing enums, struct and match syntax |
| test/corpus/script.move | basic script test for comments and placeholder main |
| test/corpus/enums.move | enum and test‐only match patterns |
| src/tree_sitter/parser.h | removed redundant forward typedef |
| src/node-types.json | added new operator tokens and marked some fields optional |
| src/grammar.json | extended JSON-based grammar with new operators, visibility, casts, type params, precedences |
| grammar.js | updated JS grammar rules to match JSON changes |
Comments suppressed due to low confidence (2)
test/corpus/test_script.move:8
- [nitpick] Function names in Move are typically snake_case. Consider renaming
some_Nametosome_namefor consistency.
fun some_Name<T: key, U: drop>(
test/corpus/test_script.move:22
- [nitpick] Parameter names should follow snake_case and be descriptive. Rename
_I_12to something likeparam_uor another meaningful identifier.
_I_12: U
| field('field', alias($.var_name, $.shorthand_field_identifier)), | ||
| seq(field('field', $.var_name), ':', field('bind', $._bind)) | ||
| seq(field('field', $.var_name), ':', field('bind', $._bind)), | ||
| '..' // TODO: Ensure this is only at the end of the binding |
There was a problem hiding this comment.
Allowing .. anywhere in a binding may lead to ambiguous destructuring patterns. It would be safer to restrict .. to appear only as the last member in the field list.
Suggested change
| '..' // TODO: Ensure this is only at the end of the binding | |
| // Removed standalone '..' as it is now handled in `_bind_fields` |
Copilot uses AI. Check for mistakes.
1. Fixes type declarations in function values 2. Fixes calling a function value as a function 3. Ensures tests are compilable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.