Skip to content

Update Selenium to 4.33.0 +semver:feature #101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 28, 2025
Merged

Update Selenium to 4.33.0 +semver:feature #101

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
687a2df
Update Selenium to 4.33.0 +semver:feature
mialeska May 28, 2025
93a8b72
fix setting of implicit wait
mialeska May 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,7 @@
<dependency>
<groupId>com.google.guava</groupId>
<artifactId>guava</artifactId>
<version>33.4.0-jre</version>
<version>33.4.8-jre</version>
</dependency>
<dependency>
<groupId>com.fasterxml.jackson.core</groupId>
Expand All @@ -131,7 +131,7 @@
<dependency>
<groupId>org.seleniumhq.selenium</groupId>
<artifactId>selenium-java</artifactId>
<version>4.28.1</version>
<version>4.33.0</version>
</dependency>
<dependency>
<groupId>io.appium</groupId>
Expand Down
3 changes: 1 addition & 2 deletions src/test/java/tests/applications/windowsApp/WindowsApplication.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@

import java.net.URL;
import java.time.Duration;
import java.util.concurrent.TimeUnit;

public class WindowsApplication implements IApplication {
private long implicitWaitSeconds;
Expand All @@ -34,7 +33,7 @@ public boolean isStarted() {
public void setImplicitWaitTimeout(Duration value) {
long valueInSeconds = value.getSeconds();
if (implicitWaitSeconds != valueInSeconds){
driver.manage().timeouts().implicitlyWait(value.toMillis(), TimeUnit.MILLISECONDS);
driver.manage().timeouts().implicitlyWait(value);
implicitWaitSeconds = valueInSeconds;
}
}
Expand Down
Loading