Update Selenium to 4.34.0 #103
Conversation
Sonatype deploy: publish with central-publishing-maven-plugin, use maven versions plugin
WalkthroughThe changes update the Maven build configuration and dependencies, including several plugin and library version upgrades, removal of snapshot and repository management, and migration to a new publishing plugin. The GitHub Actions workflow for Maven Central release is adjusted to explicitly set the project version before deployment and to streamline deployment commands. Additionally, the Azure pipeline updates SonarCloud tasks to version 3. Changes
Sequence Diagram(s)sequenceDiagram
participant GitHub Actions
participant Maven
participant Maven Central
GitHub Actions->>Maven: mvn versions:set -DnewVersion (batch mode, no backup POM)
GitHub Actions->>Maven: mvn deploy (batch mode, no release profile)
Maven->>Maven Central: Deploy artifacts
Possibly related PRs
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (2)
✅ Files skipped from review due to trivial changes (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🔭 Outside diff range comments (1)
.github/workflows/release-maven-central.yml (1)
18-27: Server-ID mismatch will break Central Publishing authentication
setup-javainjects credentials intosettings.xmlunder the server-id you specify (ossrh).
The Central Publishing Maven Plugin insidepom.xmllooks for credentials undercentral(see its<publishingServerId>setting). Unless both IDs exist insettings.xml, the deploy step will 401-fail.- server-id: ossrh + # Keep this identical to <publishingServerId> in pom.xml + server-id: centralAlternatively, change
<publishingServerId>toossrh. Pick one ID and use it consistently.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
.github/workflows/release-maven-central.yml(1 hunks)pom.xml(10 hunks)
🔇 Additional comments (2)
.github/workflows/release-maven-central.yml (1)
55-62: Environment variable names diverge from those used in Step 2Here you remap secrets to
MVN_CENTRAL_USERNAME/MVN_CENTRAL_PASSWORD, but Step 2 expected those vars earlier whensetup-javaran.
If the repository secrets are already calledOSSRH_USERNAME/OSSRH_TOKEN, expose them once at job level to avoid duplication and confusion:env: - MVN_CENTRAL_USERNAME: ${{ secrets.OSSRH_USERNAME }} - MVN_CENTRAL_PASSWORD: ${{ secrets.OSSRH_TOKEN }} - MVN_GPG_PASSPHRASE: ${{ secrets.GPG_PASSPHRASE }} + OSSRH_USERNAME: ${{ secrets.OSSRH_USERNAME }} + OSSRH_TOKEN: ${{ secrets.OSSRH_TOKEN }} + GPG_PASSPHRASE: ${{ secrets.GPG_PASSPHRASE }}Then reference these names consistently in both
setup-javaand the deploy step.
Otherwise the deploy will try to authenticate with empty credentials.pom.xml (1)
143-153: Plugin versions confirmed on Maven CentralVerified that both
maven-compiler-plugin:3.14.0andjacoco-maven-plugin:0.8.13are available on Maven Central. The build will resolve these versions successfully—no changes required.
github-project-automation
bot
moved this from In progress
to Review in progress
in Aquality Core
|
github-project-automation
bot
moved this from Review in progress
to Done
in Aquality Core
mialeska
changed the title
PR Details
Sonatype deploy: publish with central-publishing-maven-plugin, use maven versions plugin
Related Issue Link:
How Has This Been Tested
Checklist