Skip to content

Conversation

recolic
Copy link

@recolic recolic commented Sep 30, 2025

PR Description:

This PR allows creating LVM installation without separate home volume.

Tests and Checks

  • I have tested the code!

Test: default layout works
image

Test: no-home layout works
image

Test: default layout + btrfs subvol works
image

Test: no-home layout + btrfs subvol no effect (no-home is controlled inside btrfs subvol)
image

@recolic recolic marked this pull request as ready for review September 30, 2025 22:26
@recolic recolic requested a review from Torxed as a code owner September 30, 2025 22:27
@recolic
Copy link
Author

recolic commented Sep 30, 2025

I think get_default_btrfs_subvols() might also need a HomeVolume=True/False option?

@svartkanin
Copy link
Collaborator

The description on the top of the configuration still reads
Configuration: Default layout (root volume + seperate home volume) even though no home was selected.

The saved configuration also doesn't seem to store the correct value

...
        "lvm_config": {
            "config_type": "default",
            "vol_groups": [
                {
...

I'd also rename the options to be

  • Default layout
  • Root only

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants