-
Notifications
You must be signed in to change notification settings - Fork 82
Changes for migration from Provisioning 1.0 to Provisioning 2.0 #547
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
fabik111
wants to merge
3
commits into
arduino-libraries:master
Choose a base branch
from
fabik111:migration
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+60
−25
Open
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -92,30 +92,47 @@ void ClaimingHandlerClass::poll() { | |
} | ||
|
||
void ClaimingHandlerClass::getIdReqHandler() { | ||
if (_ts != 0) { | ||
byte _uhwidBytes[32]; | ||
hex::decode(_uhwid->c_str(), _uhwidBytes, _uhwid->length()); | ||
//Send UHWID | ||
ProvisioningOutputMessage idMsg = {MessageOutputType::UHWID}; | ||
idMsg.m.uhwid = _uhwidBytes; | ||
_agentManager.sendMsg(idMsg); | ||
|
||
String token = getAIoTCloudJWT(*_secureElement, *_uhwid, _ts, 1); | ||
if (token == "") { | ||
DEBUG_ERROR("CH::%s Error: token not created", __FUNCTION__); | ||
sendStatus(StatusMessage::ERROR); | ||
return; | ||
} | ||
|
||
//Send JWT | ||
ProvisioningOutputMessage jwtMsg = {MessageOutputType::JWT}; | ||
jwtMsg.m.jwt = token.c_str(); | ||
_agentManager.sendMsg(jwtMsg); | ||
_ts = 0; | ||
} else { | ||
if (_ts == 0) { | ||
DEBUG_ERROR("CH::%s Error: timestamp not provided" , __FUNCTION__); | ||
sendStatus(StatusMessage::PARAMS_NOT_FOUND); | ||
return; | ||
} | ||
|
||
byte _uhwidBytes[32]; | ||
hex::decode(_uhwid->c_str(), _uhwidBytes, _uhwid->length()); | ||
|
||
String token = generateToken(); | ||
if (token == "") { | ||
DEBUG_ERROR("CH::%s Error: token not created", __FUNCTION__); | ||
sendStatus(StatusMessage::ERROR); | ||
return; | ||
} | ||
|
||
SElementJWS sejws; | ||
String publicKey = sejws.publicKey(*_secureElement, 1, false); | ||
if (publicKey == "") { | ||
DEBUG_ERROR("CH::%s Error: public key not created", __FUNCTION__); | ||
sendStatus(StatusMessage::ERROR); | ||
return; | ||
} | ||
|
||
//Send public key | ||
ProvisioningOutputMessage publicKeyMsg = {MessageOutputType::PROV_PUBLIC_KEY}; | ||
publicKeyMsg.m.provPublicKey = publicKey.c_str(); | ||
_agentManager.sendMsg(publicKeyMsg); | ||
|
||
|
||
//Send UHWID | ||
ProvisioningOutputMessage idMsg = {MessageOutputType::UHWID}; | ||
idMsg.m.uhwid = _uhwidBytes; | ||
_agentManager.sendMsg(idMsg); | ||
|
||
//Send JWT | ||
ProvisioningOutputMessage jwtMsg = {MessageOutputType::JWT}; | ||
jwtMsg.m.jwt = token.c_str(); | ||
_agentManager.sendMsg(jwtMsg); | ||
_ts = 0; | ||
|
||
} | ||
|
||
void ClaimingHandlerClass::resetStoredCredReqHandler() { | ||
|
@@ -186,7 +203,24 @@ void ClaimingHandlerClass::getProvSketchVersionRequestCb() { | |
_receivedEvent = ClaimingReqEvents::GET_PROV_SKETCH_VERSION; | ||
} | ||
|
||
bool ClaimingHandlerClass::sendStatus(StatusMessage msg) { | ||
ProvisioningOutputMessage statusMsg = { MessageOutputType::STATUS, { msg } }; | ||
return _agentManager.sendMsg(statusMsg); | ||
String ClaimingHandlerClass::generateToken() | ||
{ | ||
String token = getAIoTCloudJWT(*_secureElement, *_uhwid, _ts, 1); | ||
if(token == "") { | ||
byte publicKey[64]; | ||
DEBUG_INFO("Generating private key"); | ||
if(!_secureElement->generatePrivateKey(1, publicKey)){ | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. use a constant to hold the private key slot, it would be much clearer |
||
DEBUG_ERROR("CH::%s Error: private key generation failed", __FUNCTION__); | ||
return ""; | ||
} | ||
token = getAIoTCloudJWT(*_secureElement, *_uhwid, _ts, 1); | ||
} | ||
|
||
return token; | ||
} | ||
|
||
bool ClaimingHandlerClass::sendStatus(StatusMessage msg) | ||
{ | ||
ProvisioningOutputMessage statusMsg = {MessageOutputType::STATUS, {msg}}; | ||
return _agentManager.sendMsg(statusMsg); | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
style: why
{
is on a new line?