Add config parameter to RS485 initialization
#27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added RS485Config
leonardocavagnis
requested changes
Jan 7, 2025
Contributor
leonardocavagnis
left a comment
leonardocavagnis
left a comment
There was a problem hiding this comment.
Thanks for contributing! 😄
This should resolve the compilation issue.
Could you please also update the RS485_fullduplex and RS485_halfduplex examples to include the config parameter?
src/RS485CommClass.cpp
Outdated
| { } | ||
|
|
||
| void RS485CommClass::begin(unsigned long baudrate, int predelay, int postdelay) { | ||
| void RS485CommClass::begin(unsigned long baudrate, uint16_t config = SERIAL_8N1, int predelay, int postdelay) { |
Contributor
There was a problem hiding this comment.
Suggested change
| void RS485CommClass::begin(unsigned long baudrate, uint16_t config = SERIAL_8N1, int predelay, int postdelay) { | |
| void RS485CommClass::begin(unsigned long baudrate, uint16_t config, int predelay, int postdelay) { |
leonardocavagnis
changed the title
config parameter to RS485 initialization
leonardocavagnis
added
type: enhancement
|
|
|
Memory usage change @ bf6efca
Click for full report table
Click for full report CSV |
Author
|
Hello Leonardo |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dear all
I recently updated my projects to the new repository. When using RS485, I noticed that there is no option to set the UART Config. This PR adds this option back in.