Wifi library: extending apis and improving library #28
andreagilardonicheckpatch.yml
on: pull_request
checkpatch review
17s
Annotations
10 errors
|
checkpatch review:
libraries/SocketWrapper/WiFi.h#L95
ERROR: open brace '{' following function definitions go on the next line
|
|
checkpatch review:
libraries/SocketWrapper/WiFi.h#L95
ERROR: "foo* bar" should be "foo *bar"
|
|
checkpatch review:
libraries/SocketWrapper/WiFi.h#L95
ERROR: Bad function definition - char* SSID() should probably be char* SSID(void)
|
|
checkpatch review:
libraries/SocketWrapper/WiFi.h#L95
WARNING: please, no spaces at the start of a line
|
|
checkpatch review:
libraries/SocketWrapper/WiFi.h#L83
WARNING: suspect code indent for conditional statements (12, 12)
|
|
checkpatch review:
libraries/SocketWrapper/WiFi.h#L83
WARNING: Statements should start on a tabstop
|
|
checkpatch review:
libraries/SocketWrapper/WiFi.h#L78
WARNING: suspect code indent for conditional statements (8, 12)
|
|
checkpatch review:
libraries/SocketWrapper/WiFi.h#L78
WARNING: please, no spaces at the start of a line
|
|
checkpatch review:
libraries/SocketWrapper/WiFi.h#L78
ERROR: code indent should use tabs where possible
|
|
checkpatch review
WARNING: Missing commit description - Add an appropriate one
|