Added snapshot_inv() and init_inv() to DepleteReactor.py#26
Open
SamarAbdelkawy wants to merge 3 commits intoarfc:mainfrom
Open
Added snapshot_inv() and init_inv() to DepleteReactor.py#26SamarAbdelkawy wants to merge 3 commits intoarfc:mainfrom
SamarAbdelkawy wants to merge 3 commits intoarfc:mainfrom
Conversation
Collaborator
|
I'll look more at the code next week, and see if I can figure out why the depletion solver isn't running. The unit tests aren't passing, and nothing in this PR should be causing them to fail; that might be something you can look at in the mean time (maybe needs to be a separate PR if it's unrelated to this one). Also, the CHANGELOG test is failing, because didn't update that for this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes
Following the issue of <explicit_inventory> flag in the input causes the core count to drop to zero every time step in the simulation, while this flag doesn't cause any issues in the C++ archetypes. I noticed two main functions that may be responsible to capture the inventory changes when this flag is on.
Two functions are SnapshotInv() and InitInv() as they exist in Cycamore archetypes, so I tried to follow the way they are defined inside Cycamore and added them to OpenMCyclus archetype.
Adding the functions fixed the issue of having an empty core suddenly in Tick, and now the count is correct, compared to running the simulation without the <explicit_inventory> flag at all.
One bug that still persists is that during the transmutation step, the fuel still doesn't go through the depletion step and jumps directly to discharging. My thoughts are that those two functions still need some edits, or to be defined in some other way to be able to capture the full functionality.
Types of changes
Associated Issues and PRs
explicit_inventoryoption #23Associated Developers
Checklist for Reviewers
Reviewers should use this link to get to the
Review Checklist before they begin their review.