Skip to content

Conversation

agaudreault
Copy link
Member

The code is simple, but unit test framework is not setup to test the KubectlResourceOperation struct.

This struct is mocked by the sync context tests.

The unit tests will come in another PR (#758), but we can ship this fix first.

Signed-off-by: Alexandre Gaudreault <[email protected]>
@agaudreault agaudreault requested a review from a team as a code owner August 19, 2025 14:43
Copy link

Copy link

codecov bot commented Aug 19, 2025

Codecov Report

❌ Patch coverage is 0% with 18 lines in your changes missing coverage. Please review.
✅ Project coverage is 47.05%. Comparing base (8849c3f) to head (315e655).
⚠️ Report is 57 commits behind head on master.

Files with missing lines Patch % Lines
pkg/utils/kube/resource_ops.go 0.00% 18 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #759      +/-   ##
==========================================
- Coverage   54.26%   47.05%   -7.22%     
==========================================
  Files          64       64              
  Lines        6164     6550     +386     
==========================================
- Hits         3345     3082     -263     
- Misses       2549     3212     +663     
+ Partials      270      256      -14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@agaudreault agaudreault enabled auto-merge (squash) August 19, 2025 14:53
Copy link
Contributor

@pjiang-dev pjiang-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@crenshaw-dev crenshaw-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Argo CD tests pass in CI.

I also tested TestJobHookPreSyncForceReplace from argoproj/argo-cd#23697 locally, and this PR fixes the test failure.

@agaudreault agaudreault merged commit dc952c1 into argoproj:master Aug 27, 2025
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants