Adding a check to avoid recursive type definitions#329
Open
rodrigogribeiro wants to merge 8 commits intomainfrom
Open
Adding a check to avoid recursive type definitions#329rodrigogribeiro wants to merge 8 commits intomainfrom
rodrigogribeiro wants to merge 8 commits intomainfrom
Conversation
Collaborator
rodrigogribeiro
commented
Mar 11, 2026
rodrigogribeiro
commented
- This PR adds a check which do not allow the declaration of recursive types (direct or indirect).
- Add new tests and changes some tests to failing due to the use of recursive types.
* This PR adds a check which do not allow the declaration of recursive types (direct or indirect). * Add new tests and changes some tests to failing due to the use of recursive types.
* New test added.
mbenke
reviewed
Mar 12, 2026
Collaborator
mbenke
left a comment
mbenke
left a comment
There was a problem hiding this comment.
I wonder whether just switching tests to 'expect failure' is the right way to go.
Also, we should think whether we want to allow recursive types in comptime.
Y-Nak
requested changes
Mar 14, 2026
* Adding an example suggested by Y-Nak.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.