Skip to content

Conversation

clonker
Copy link
Member

@clonker clonker commented Aug 27, 2025

Also I had to implement a skip mechanism for the formal correctness proofs so that it wouldn't try to run the README.md as python script.

@clonker clonker force-pushed the docs_update_links branch 2 times, most recently from 71fc9f1 to c388171 Compare August 27, 2025 11:53
@r0qs r0qs force-pushed the docs_update_links branch from 08ba119 to b98508c Compare August 27, 2025 16:55
@cameel cameel changed the title Update links to github orgas argotorg and ipsilon where appropriate Update links to github org as argotorg and ipsilon where appropriate Aug 27, 2025
@cameel
Copy link
Collaborator

cameel commented Aug 27, 2025

If you haven't done so yet, I think it would be good to run linkcheck to verify that URLs are not broken after this change, at least in the docs.

@r0qs r0qs force-pushed the docs_update_links branch from d75ee59 to b002534 Compare August 28, 2025 13:12
@r0qs r0qs force-pushed the docs_update_links branch from b002534 to 69af5ee Compare August 28, 2025 14:21

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

Copy link

solbuildpackpusher/solidity-buildpack-deps:ubuntu.clang.ossfuzz-11 [solbuildpackpusher/solidity-buildpack-deps@sha256:d1d7d0fd5a290473d5bad521ba899ef7f674c78603cca3f32b4a555ac9325287].

Copy link

solbuildpackpusher/solidity-buildpack-deps:ubuntu2404-4 [solbuildpackpusher/solidity-buildpack-deps@sha256:b29b1c1a09f32dad8b55ae876ce9809b55213cd1c9ea963099a0b1e192cfc5b8].

Copy link

solbuildpackpusher/solidity-buildpack-deps:ubuntu2204-3 [solbuildpackpusher/solidity-buildpack-deps@sha256:9543db6e957d63a6413b075e4e5a88651cd8a0a64423554ad3b308908b0c6811].

Copy link

solbuildpackpusher/solidity-buildpack-deps:ubuntu2404.clang-5 [solbuildpackpusher/solidity-buildpack-deps@sha256:a4cf84f866e5408926a5bc4286bde75c71223982a5da0f2549e29a87cd08a2a5].

matheusaaguiar
matheusaaguiar previously approved these changes Sep 3, 2025
@r0qs r0qs merged commit 4d07239 into develop Sep 8, 2025
76 of 80 checks passed
@r0qs r0qs deleted the docs_update_links branch September 8, 2025 18:29
if: "env.DOCKER_IMAGE"
# NOTE: Can't update to v1.3.1 due to an error: `/entrypoint.sh:5:in 'require_relative': cannot load such file -- /lib/github (LoadError)`
uses: unsplash/comment-on-pr@ffe8f97ccc63ce12c3c23c6885b169db67958d3b #v1.3.0
uses: thollander/actions-comment-pull-request@v3
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should pin actions to hashes rather than tags, the way it was done here before this change. Even github recommends that now. Apparently there's also an org-level policy to require that. We should enable it. See Using third-party actions.

@cameel
Copy link
Collaborator

cameel commented Sep 9, 2025

You did not update the hashes in CI config to the ones generated above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants