-
Notifications
You must be signed in to change notification settings - Fork 6.2k
Update links to github org as argotorg and ipsilon where appropriate #16184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
71fc9f1
to
c388171
Compare
08ba119
to
b98508c
Compare
If you haven't done so yet, I think it would be good to run |
d75ee59
to
b002534
Compare
b002534
to
69af5ee
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
|
|
|
|
if: "env.DOCKER_IMAGE" | ||
# NOTE: Can't update to v1.3.1 due to an error: `/entrypoint.sh:5:in 'require_relative': cannot load such file -- /lib/github (LoadError)` | ||
uses: unsplash/comment-on-pr@ffe8f97ccc63ce12c3c23c6885b169db67958d3b #v1.3.0 | ||
uses: thollander/actions-comment-pull-request@v3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should pin actions to hashes rather than tags, the way it was done here before this change. Even github recommends that now. Apparently there's also an org-level policy to require that. We should enable it. See Using third-party actions.
You did not update the hashes in CI config to the ones generated above. |
Also I had to implement a skip mechanism for the formal correctness proofs so that it wouldn't try to run the README.md as python script.