Skip to content

Fix Foundry 403 errors for external PRs#16473

Merged
r0qs merged 1 commit intodevelopfrom
fix-gh-api-limit-foundry-circleci
Mar 19, 2026
Merged

Fix Foundry 403 errors for external PRs#16473
r0qs merged 1 commit intodevelopfrom
fix-gh-api-limit-foundry-circleci

Conversation

@r0qs
Copy link
Member

@r0qs r0qs commented Feb 17, 2026

Our external tests are failing with 403 errors due to GitHub API rate limits. This is because external contributors don't have access to GITHUB_READ_TOKEN, unauthenticated API calls would get rate-limited, as seen in https://app.circleci.com/pipelines/github/argotorg/solidity/41722/workflows/b53b2c11-7aa9-4230-89d0-ad84b55f11e7/jobs/1959253.

This PR replaces the GitHub API calls with publicly accessible release attestations, which don't seem to require authentication.

@r0qs r0qs self-assigned this Feb 17, 2026
@github-actions github-actions bot added the stale The issue/PR was marked as stale because it has been open for too long. label Mar 7, 2026
@argotorg argotorg deleted a comment from github-actions bot Mar 9, 2026
@r0qs r0qs removed the stale The issue/PR was marked as stale because it has been open for too long. label Mar 9, 2026
Copy link
Member

@clonker clonker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider making foundry_version a mandatory parameter in install_foundry.

clonker
clonker previously approved these changes Mar 19, 2026
@r0qs r0qs force-pushed the fix-gh-api-limit-foundry-circleci branch from 028172f to 9573223 Compare March 19, 2026 10:27
@r0qs
Copy link
Member Author

r0qs commented Mar 19, 2026

Consider making foundry_version a mandatory parameter in install_foundry.

I don't think it needs to be mandatory, since it's currently only used by external tests. However, I noticed that those external tests were using the nightly version. I've updated them to use the default foundry version instead (i.e., stable).

@r0qs r0qs force-pushed the fix-gh-api-limit-foundry-circleci branch from 9573223 to 6990192 Compare March 19, 2026 10:28
@r0qs r0qs enabled auto-merge March 19, 2026 10:33
@r0qs r0qs merged commit 64bba94 into develop Mar 19, 2026
83 checks passed
@r0qs r0qs deleted the fix-gh-api-limit-foundry-circleci branch March 19, 2026 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants