Skip to content

Conversation

Sichao25
Copy link
Collaborator

@Sichao25 Sichao25 commented Oct 20, 2023

Replace pull request 260. We would like to enable 3D quiver and scatter plot in dynamo.

  • debug existing 3D scatter, quivers and streamtube.
  • enable plot quiver for 3 different genes or data from different layers
  • remove 3d options in cell_wise_vector function and make it a separate function.
  • use other methods, including PyVista and Plotly to implement the 3D scatters / quiver plots
  • Implementing 3D animation.

Two functionalities need further improvement. Will describe at details in a GitHub Issue.

  • The 3D vectors (Cone) plot implemented by Plotly doesn't support customized coloring.
  • Plotly animation doesn't move.

@codecov-commenter
Copy link

codecov-commenter commented Oct 20, 2023

Codecov Report

Merging #595 (926bf54) into master (1e8ffe4) will decrease coverage by 0.41%.
The diff coverage is 6.05%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@            Coverage Diff             @@
##           master     #595      +/-   ##
==========================================
- Coverage   22.54%   22.14%   -0.41%     
==========================================
  Files         166      166              
  Lines       27362    27975     +613     
==========================================
+ Hits         6168     6194      +26     
- Misses      21194    21781     +587     
Files Coverage Δ
dynamo/movie/__init__.py 100.00% <100.00%> (ø)
dynamo/plot/__init__.py 100.00% <100.00%> (ø)
dynamo/movie/utils.py 30.00% <60.00%> (+5.00%) ⬆️
dynamo/plot/streamtube.py 15.00% <0.00%> (-0.79%) ⬇️
dynamo/vectorfield/topography.py 23.11% <10.41%> (-1.29%) ⬇️
dynamo/plot/scVectorField.py 5.80% <1.66%> (-0.32%) ⬇️
dynamo/movie/fate.py 15.30% <15.62%> (-1.01%) ⬇️
dynamo/plot/utils.py 18.22% <6.71%> (-2.89%) ⬇️
dynamo/plot/scatters.py 33.95% <2.46%> (-16.36%) ⬇️
dynamo/plot/topography.py 5.58% <1.72%> (-1.58%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Sichao25 Sichao25 marked this pull request as ready for review October 31, 2023 21:05
@Xiaojieqiu Xiaojieqiu merged commit 9a687cc into aristoteleo:master Nov 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants