Skip to content

Fix symbolic link preview #156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Fix symbolic link preview #156

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
224ed96
Follow link to get preview
flohw Jul 11, 2025
694d3fe
Make preview always return an array
flohw Jul 11, 2025
c1fced5
Check if html index exists before using it
flohw Jul 11, 2025
a3365a9
Return specific array to handle link file type
flohw Jul 11, 2025
c48cfdb
Add info about target link
flohw Jul 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Resources/views/views/_list.html.twig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@
</td>
<td>
{% block file_preview %}
{{ fileEntity.preview ? fileEntity.preview.html|raw }}
{{ fileEntity.preview.html is defined ? fileEntity.preview.html|raw }}
{% endblock %}
</td>
<td data-value="{{ file.fileName }}" {{ fileEntity.attribut|raw }}>
Expand Down Expand Up @@ -125,4 +125,4 @@
{% endfor %}
</tbody>
</table>
</div>
</div>
2 changes: 1 addition & 1 deletion Resources/views/views/_thumbnail.html.twig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
{% endblock %}
{% block file_preview %}
<div class="thumbnail-img">
{{ fileEntity.preview ? fileEntity.preview.html|raw }}
{{ fileEntity.preview.html is defined ? fileEntity.preview.html|raw }}
</div>
{% endblock %}
<p {{ fileEntity.attribut|raw }}>
Expand Down
19 changes: 17 additions & 2 deletions Service/FileTypeService.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ class FileTypeService {
public function __construct(private RouterInterface $router, private Environment $twig) {
}

public function preview(FileManager $fileManager, SplFileInfo $file) {
public function preview(FileManager $fileManager, SplFileInfo $file): array {

if ($fileManager->getImagePath()) {
$filePath = $fileManager->getImagePath().rawurlencode($file->getFilename());
Expand All @@ -37,7 +37,6 @@ public function preview(FileManager $fileManager, SplFileInfo $file) {
return $this->fileIcon($filePath, $extension, $size, true, $fileManager->getConfigurationParameter('twig_extension'), $fileManager->getConfigurationParameter('cachebreaker'));
}
if ('dir' === $type) {

$href = $this->router->generate(
'file_manager', array_merge(
$fileManager->getQueryParameters(),
Expand All @@ -51,6 +50,22 @@ public function preview(FileManager $fileManager, SplFileInfo $file) {
'folder' => '<a href="'.$href.'">'.$file->getFilename().'</a>',
];
}
if ('link' === $type) {
$href = $this->router->generate(
'file_manager', array_merge(
$fileManager->getQueryParameters(),
['route' => $fileManager->getRoute().'/'.$file->getFilename()],
),
);

return [
'path' => $filePath,
'html' => "<i class='fas fa-link' aria-hidden='true'></i>",
'folder' => '<a href="'.$href.'">'.$file->getFilename().'&nbsp;&rarr;&nbsp;'.$file->getLinkTarget().'</a>',
];
}

return [];
}

public function accept($type): bool|string {
Expand Down