Skip to content

Conversation

MounirDhahri
Copy link
Member

Description

This is a first POC implementation of tracking artwork impressions on Artwork screens.

A few things are left to figure out here:

  • The sticky bottom is messing up the computation logic because it's on top of the screen
  • This API isn't as fancy as the viewability config pairs from RN and currently doesn't support minimum view duration. Maybe it's possible to add it though.

Other paths tried
I tried the viewability config pairs but because it's 2 nested scrollviews, it quickly got so complicated I got lost in the maths.

PR Checklist

  • I have tested my changes on the following platforms:
    • Android.
    • iOS.
  • I hid my changes behind a feature flag, or they don't need one.
  • I have included screenshots or videos at least on Android, or I have not changed the UI.
  • I have added tests, or my changes don't require any.
  • I added an app state migration, or my changes do not require one.
  • I have documented any follow-up work that this PR will require, or it does not require any.
  • I have added a changelog entry below, or my changes do not require one.

To the reviewers 👀

  • I would like at least one of the reviewers to run this PR on the simulator or device.
Changelog updates

Changelog updates

Cross-platform user-facing changes

iOS user-facing changes

Android user-facing changes

Dev changes

Need help with something? Have a look at our docs, or get in touch with us.

@ArtsyOpenSource
Copy link
Contributor

Warnings
⚠️

An error occurred while validating your changelog, please make sure you provided a valid changelog.

Generated by 🚫 dangerJS against 8c5b8a5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants