Skip to content

Conversation

@MounirDhahri
Copy link
Member

@MounirDhahri MounirDhahri commented Oct 7, 2025

This PR resolves PHIRE-2370

Description

This PR upgrades react-navigation to the latest version.

Why?
The new version have minor new architecture fixes that helped improve the fps on this PR #12819

Screenshot 2025-10-07 at 12 48 01

PR Checklist

  • I have tested my changes on the following platforms:
    • Android.
    • iOS.
  • I hid my changes behind a feature flag, or they don't need one.
  • I have included screenshots or videos at least on Android, or I have not changed the UI.
  • I have added tests, or my changes don't require any.
  • I added an app state migration, or my changes do not require one.
  • I have documented any follow-up work that this PR will require, or it does not require any.
  • I have added a changelog entry below, or my changes do not require one.

To the reviewers 👀

  • I would like at least one of the reviewers to run this PR on the simulator or device.
Changelog updates

Changelog updates

Cross-platform user-facing changes

iOS user-facing changes

Android user-facing changes

Dev changes

  • upgrade react-navigation to latest - mounir

Need help with something? Have a look at our docs, or get in touch with us.

@MounirDhahri MounirDhahri requested a review from gkartalis October 7, 2025 10:48
@MounirDhahri MounirDhahri self-assigned this Oct 7, 2025
@ArtsyOpenSource
Copy link
Contributor

ArtsyOpenSource commented Oct 7, 2025

This PR contains the following changes:

  • Dev changes (upgrade react-navigation to latest - mounir - MounirDhahri)

Generated by 🚫 dangerJS against db98951

@MounirDhahri MounirDhahri added the Squash On Green A label to indicate that Peril should squash-merge this PR when all statuses are green label Oct 7, 2025
@gkartalis gkartalis removed the Squash On Green A label to indicate that Peril should squash-merge this PR when all statuses are green label Oct 7, 2025
@MounirDhahri MounirDhahri added the Squash On Green A label to indicate that Peril should squash-merge this PR when all statuses are green label Oct 7, 2025
@artsy-peril artsy-peril bot merged commit c02d7b5 into main Oct 7, 2025
8 checks passed
@artsy-peril artsy-peril bot deleted the chore/upgrade-react-navigation-to-latest branch October 7, 2025 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Jira Synced Squash On Green A label to indicate that Peril should squash-merge this PR when all statuses are green

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants