chore(DIAM-10): Add telemetry for less than 5 artworks being returned in discover daily - #12849
Merged
lilyfromseattle merged 3 commits intoOct 21, 2025
Merged
Conversation
… in discover daily
Contributor
Contributor
|
Important too, please add a changelog entry, dangerJS is warning us here. |
araujobarret
previously approved these changes
Oct 16, 2025
| export const useArtworksTelemetry = (artworks: InfiniteDiscoveryArtwork[]) => { | ||
| useEffect(() => { | ||
| if (artworks.length < 5) { | ||
| captureMessage( |
Member
There was a problem hiding this comment.
Is having a breadcrumb what you want here or know how often this happens? if the latter, I suggest also looking into using volley for this kind of data! it would be more accessible and would be more actionable.
You can try something like
volleyClient.send({
type: "increment",
name: "graphql-request-with-errors",
tags: [`count:${artworks.length}`],
})Happy to help building a dashboard for this as well if it makes sense
Contributor
Author
There was a problem hiding this comment.
Thanks for the suggestion! We ended up going that route
lilyfromseattle
deleted the
lilyfromseattle/sentry-for-discover-daily-artworks
branch
October 21, 2025 15:33
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR resolves DIAM-10
Description
After consulting with @iskounen we decided to first add telemetry to see if the issue described in the ticket is actually happening before we implement a fix/investigate further
PR Checklist
To the reviewers 👀
Changelog updates
Changelog updates
Cross-platform user-facing changes
iOS user-facing changes
Android user-facing changes
Dev changes
Need help with something? Have a look at our docs, or get in touch with us.