Skip to content

Conversation

@dtnaughton
Copy link

  • Added onPageChange hook which fires on router path change.
  • Function is passed into plugin as an argument. If no function is passed, generic blank function is set.
  • Function currently gets args from the plugin itself (search query, current path and next path). Sufficient for now but could be made more generic by not relying on these args.

@dtnaughton dtnaughton closed this by deleting the head repository Dec 5, 2022
@dtnaughton dtnaughton reopened this Dec 6, 2022
@dtnaughton dtnaughton marked this pull request as draft December 21, 2022 16:46
@dtnaughton dtnaughton marked this pull request as ready for review December 21, 2022 16:47
@jenessaman jenessaman self-requested a review December 21, 2022 20:24
@jenessaman
Copy link

jenessaman commented Dec 21, 2022

Implementation is based on: z3by#37 (@dtnaughton - its worth putting a link in a comment, so we can refer back to this original issue and basis for implementation if needed)

@dtnaughton
Copy link
Author

closed PR because original branch was accidentally deleted. Opened a new PR which captures all changes in this PR and additional changes related to these comments #2

@dtnaughton dtnaughton closed this Dec 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants