Skip to content

feat: remove multiple plugins at once #2163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+32 −26
Open

feat: remove multiple plugins at once #2163

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
58 changes: 32 additions & 26 deletions internal/cli/cli.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -223,7 +223,7 @@ func Execute(version string) {
Name: "remove",
Action: func(_ context.Context, cmd *cli.Command) error {
args := cmd.Args()
return pluginRemoveCommand(cmd, logger, args.Get(0))
return pluginRemoveCommand(cmd, logger, args.Slice()...)
},
},
{
Expand Down Expand Up @@ -736,36 +736,42 @@ func pluginAddCommand(_ *cli.Command, conf config.Config, logger *log.Logger, pl
return nil
}

func pluginRemoveCommand(_ *cli.Command, logger *log.Logger, pluginName string) error {
if pluginName == "" {
logger.Print("No plugin given")
cli.OsExiter(1)
return nil
}
func pluginRemoveCommand(_ *cli.Command, logger *log.Logger, pluginNames ...string) error {
for _, pluginName := range pluginNames {
if pluginName == "" {
logger.Print("No plugin given")
cli.OsExiter(1)
return nil
}

conf, err := config.LoadConfig()
if err != nil {
logger.Printf("error loading config: %s", err)
return err
}
conf, err := config.LoadConfig()
if err != nil {
logger.Printf("error loading config: %s", err)
return err
}

err = plugins.Remove(conf, pluginName, os.Stdout, os.Stderr)
if err != nil {
// Needed to match output of old version
logger.Printf("%s", err)
}
err = plugins.Remove(conf, pluginName, os.Stdout, os.Stderr)
if err != nil {
// Needed to match output of old version
logger.Printf("%s", err)
}

// This feels a little hacky but it works, to re-generate shims we delete them
// all and generate them again.
err2 := shims.RemoveAll(conf)
if err2 != nil {
logger.Printf("%s", err2)
cli.OsExiter(1)
return err2
// This feels a little hacky but it works, to re-generate shims we delete them
// all and generate them again.
err2 := shims.RemoveAll(conf)
if err2 != nil {
logger.Printf("%s", err2)
cli.OsExiter(1)
return err2
}

shims.GenerateAll(conf, os.Stdout, os.Stderr)
if err != nil {
return err
}
}

shims.GenerateAll(conf, os.Stdout, os.Stderr)
return err
return nil
}

func pluginListCommand(cCtx *cli.Command, logger *log.Logger) error {
Expand Down