Skip to content

fix OpenSSL 3.5.0 DTLS 1.2 Learning problem & update CI test - #183

Closed
c-southwest wants to merge 1 commit into
assist-project:test-openssl-3.5.0from
c-southwest:test-openssl-3.5.0-fix
Closed

c-southwest wants to merge 1 commit into
assist-project:test-openssl-3.5.0from
c-southwest:test-openssl-3.5.0-fix

Conversation

@c-southwest

Copy link
Copy Markdown
Collaborator

@kostis This PR should fix the problem mentioned in PR #182

Today, I discussed with @pfg666, and I realized that there is no patch file for OpenSSL 3.5.0. I think maybe this could be the reason why learning has strange problems. After experimentation, it turns out it is the reason for the strange problem.

@kostis

kostis commented May 6, 2025

Copy link
Copy Markdown
Contributor

Why is this a different PR rather than continuing on the branch of the PR?

@c-southwest

Copy link
Copy Markdown
Collaborator Author

Why is this a different PR rather than continuing on the branch of the PR?

I don't have permission or the right to commit changes directly to the repository.

Push failed
dtls-fuzzer: remote: Permission to assist-project/dtls-fuzzer.git denied to c-southwest. unable to access 'https://github.com/assist-project/dtls-fuzzer.git/': The requested URL returned error: 403

@kostis

kostis commented May 6, 2025

Copy link
Copy Markdown
Contributor

Added you as a collaborator - you should have received an invite.

@c-southwest

Copy link
Copy Markdown
Collaborator Author

Added you as a collaborator - you should have received an invite.

Yes, and I accepted now.

Should I push commit into your original PR, or you just merge this PR? I think both methods will have the same result.

@kostis

kostis commented May 6, 2025

Copy link
Copy Markdown
Contributor

I think it's better to continue on the original PR. I have some more (uncommitted) changes there, e.g. testing a 3.5.0 client that should also be added before the PR is merged.

@c-southwest

c-southwest commented May 6, 2025 •

Copy link
Copy Markdown
Collaborator Author

I think you may miss something:
I want to merge 1 commit into assist-project:test-openssl-3.5.0 from c-southwest:test-openssl-3.5.0-fix

This PR will be merged into your original PR (not master branch), so if you merge this PR, the commit inside this PR will be added into your PR. That's why I say both methods will have the same result.

@c-southwest

Copy link
Copy Markdown
Collaborator Author

I pushed my commit into your original PR now.
I think I can close this PR

@kostis

kostis commented May 6, 2025

Copy link
Copy Markdown
Contributor

I think you may miss something:
I want to merge 1 commit into assist-project:test-openssl-3.5.0 from c-southwest:test-openssl-3.5.0-fix

Yes, you are right. I had missed that. (Actually, did not know it was possible to have a PR for another PR... I've learned something today!)

@c-southwest c-southwest closed this May 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants