Use PEP 639 license information for Ruff itself instead of classifier #19499
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Declare licenses using only these two fields, as per PEP 639: * license: SPDX license expression consisting of one or more license identifiers * license-files: list of license file glob patterns Supported by maturin ≥ 1.9.0: https://www.maturin.rs/changelog.html
vivodi
reviewed
Jul 24, 2025
| "Development Status :: 5 - Production/Stable", | ||
| "Environment :: Console", | ||
| "Intended Audience :: Developers", | ||
| "License :: OSI Approved :: MIT License", |
There was a problem hiding this comment.
Because PEP639 expects only licence and licence-files.
It's redundant with:
license = "MIT"
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
There was a problem hiding this comment.
Sorry, that PEP does indeed recommend removing the license classifier: https://peps.python.org/pep-0639/#deprecate-license-classifiers — I hadn’t looked at it carefully before.
konstin
reviewed
Jul 27, 2025
konstin
approved these changes
Jul 27, 2025
konstin
changed the title
konstin
added
documentation
|
I removed the documentation label so that it appears under the "Other" section (we tend to remove the Documentation section in releases) |
|
I see this PR has been fully reverted:
Will you @DimitriPapadopoulos have time to look into it? |
|
Unfortunately #19624 lacks context. Is the problem that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Declare licenses using only these two fields, as per PEP 639:
license: SPDX license expression consisting of one or more license identifierslicense-files: list of license file glob patternsSupported by maturin ≥ 1.9.0:
https://www.maturin.rs/changelog.html
Test Plan
N/A