Skip to content

[playground] Fix quick fixes for empty ranges in playground #20599

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 29, 2025
Merged

[playground] Fix quick fixes for empty ranges in playground #20599

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5ff2c43
fix-20594
danparizher Sep 27, 2025
156f27b
Simplify
MichaReiser Sep 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 10 additions & 11 deletions playground/ruff/src/Editor/SourceEditor.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,17 +125,16 @@ class RuffCodeActionProvider implements CodeActionProvider {
): languages.ProviderResult<languages.CodeActionList> {
const actions = this.diagnostics
// Show fixes for any diagnostic whose range intersects the requested range
.filter((check) =>
Range.areIntersecting(
new Range(
check.start_location.row,
check.start_location.column,
check.end_location.row,
check.end_location.column,
),
range,
),
)
.filter((check) => {
const diagnosticRange = new Range(
check.start_location.row,
check.start_location.column,
check.end_location.row,
check.end_location.column,
);

return Range.areIntersectingOrTouching(diagnosticRange, range);
})
.filter(({ fix }) => fix)
.map((check) => ({
title: check.fix
Expand Down
Loading