Skip to content

Conversation

@StrahilKazlachev
Copy link
Contributor

Add simple tests for the shadow DOM <slot> emulation.
Left some commented out expectations. All related to unnecessary creation of the <slot>s fallback. The fix for nested <slot>s seems simple(#639). How to fix the same for the PassThroughSlot seems somewhat complicated, like:

<template class="slot2slot">
  <element-with-slot>
    <slot slot="named">
      <p>slot2slot fallback</p>
    </slot>
  </element-with-slot>
</template>

Did not cover usage of template controller as slotable like:

<element-with-slot>
  <p slot="named" if.bind="someCondition">Override</p>
</element-with-slot>

@EisenbergEffect
Copy link
Contributor

@StrahilKazlachev Is this and #639 ready to merge as at least an incremental improvement?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants