Conversation
BabyCNM
left a comment
There was a problem hiding this comment.
LGTM. I cannot test o1 yet because of limited access. However, the implementation looks great.
A lint question: should we rename "map_params" to "_map_params" for readability?
BabyCNM
left a comment
There was a problem hiding this comment.
The 'num_tokens' change and test updates are good to have.
…ms to _map_params
|
@marklysze could you check the build error? It indicates some problem with the token counting. |
This should be related to the change in count_token function. |
All good, committing correction shortly Update: committed |
|
@qingyun-wu could you make sure there's an o1 endpoint in the config list used by the openai CI? |
Why are these changes needed?
OpenAI has just released o1-mini and o1-preview, these changes add support for the model.
I don't have level 5 API access to test against the API, if anyone can test with the models that would be great.
Notes:
max_tokensandmax_completion_tokensshould be used. Code mapsmax_tokenstomax_completion_tokens.Tests still TODO.
Related issue number
Checks