Skip to content

Raise the BufWriter capacity to avoid blocking on writes #1230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

Raise the BufWriter capacity to avoid blocking on writes #1230

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion src/language_client.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2273,7 +2273,15 @@ impl LanguageClient {
.stdout
.ok_or_else(|| anyhow!("Failed to get subprocess stdout"))?,
));
let writer = Box::new(BufWriter::new(
// Allocate a much larger buffer size (1 megabyte instead of the BufWriter default of 8kb)
// so that Vim's ui doesn't get blocked when waiting to write to a language server
// that is doing work instead of reading from stdin
// (e.g. if the server is single threaded).
//
// On linux, the pipe buffer size defaults to 8 kilobytes.
// TCP allows much larger buffers than pipe buffers.
let writer = Box::new(BufWriter::with_capacity(
1000000,
process
.stdin
.ok_or_else(|| anyhow!("Failed to get subprocess stdin"))?,
Expand Down