PARTIAL sync: coreth PR #963,981,1009: nodeType w/o serialization
#1815
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alarso16
reviewed
Oct 15, 2025
alarso16
approved these changes
Oct 15, 2025
The serialization changes certainly could be breaking - I will defer to @ceyonur. Additionally if they are, maybe the Granite upgrade would work well? |
| Start []byte `serialize:"true"` | ||
| End []byte `serialize:"true"` | ||
| Limit uint16 `serialize:"true"` | ||
| NodeType NodeType `serialize:"false"` |
| nodeType := leafsRequest.NodeType | ||
| // TODO(JonathanOppenheimer):Handle legacy requests where NodeType was not serialized (defaults to 0) | ||
| // In this interim period, we treat NodeType 0 as StateTrieNode | ||
| if nodeType == 0 { |
There was a problem hiding this comment.
here we manually set the type.
JonathanOppenheimer
changed the title
nodeType and related items nodeType w/o serialization
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
This breaks up #1679