Skip to content

sync: coreth PR #1360: test: Fix mempool flakes #1834

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+26 −141
Open

sync: coreth PR #1360: test: Fix mempool flakes #1834

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 25 additions & 0 deletions plugin/evm/gossip_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,9 @@ package evm

import (
"context"
"crypto/ecdsa"
"math/big"
"strings"
"testing"
"time"

Expand Down Expand Up @@ -110,3 +112,26 @@ func setupPoolWithConfig(t *testing.T, config *params.ChainConfig, fundedAddress

return txPool
}

func getValidEthTxs(key *ecdsa.PrivateKey, count int, gasPrice *big.Int) []*types.Transaction {
res := make([]*types.Transaction, count)

to := common.Address{}
amount := big.NewInt(0)
gasLimit := uint64(37000)

for i := 0; i < count; i++ {
tx, _ := types.SignTx(
types.NewTransaction(
uint64(i),
to,
amount,
gasLimit,
gasPrice,
[]byte(strings.Repeat("aaaaaaaaaa", 100))),
types.HomesteadSigner{}, key)
tx.SetTime(time.Now().Add(-1 * time.Minute))
res[i] = tx
}
return res
}
139 changes: 0 additions & 139 deletions plugin/evm/gossiper_eth_gossiping_test.go
View file
Open in desktop

This file was deleted.

3 changes: 1 addition & 2 deletions scripts/known_flakes.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,9 @@ TestChainIndexerWithChildren
TestClientCancelWebsocket
TestClientWebsocketLargeMessage
TestGolangBindings
TestMempoolEthTxsAppGossipHandling
TestResumeSyncAccountsTrieInterrupted
TestResyncNewRootAfterDeletes
TestTransactionSkipIndexing
TestVMShutdownWhileSyncing
TestWaitDeployedCornerCases
TestWebsocketLargeRead
TestWebsocketLargeRead
Copy link
Contributor Author

@alarso16 alarso16 Nov 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, unclear to me why there's a diff here

Copy link
Member

@JonathanOppenheimer JonathanOppenheimer Nov 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how weird

Loading