remove unused MutexQueue and unused sync.WaitGroup #62
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kirugan
force-pushed
the
remove-unused-code-in-pkg-transport-handler
branch
from
ede7ff3 to
f1cf23b
Compare
kirugan
commented
Feb 15, 2021
| callCh <- respRoutine | ||
| } | ||
| wg.Wait() | ||
| close(callCh) |
Contributor
Author
There was a problem hiding this comment.
A few clarifications:
- control flow will never reach this point in code (it's either return from one of exit points inside the loop or keep pushing
respRoutineinsidecallChchannel) - all exit points have
closeoperation oncallCh
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.