Skip to content

Conversation

tylerjroach
Copy link
Member

The challenge was starting even before the face was a proper distance away. Before the no-light PR, readyForOval was not set until the initial face distance check had passed. This corrects the previous behavior of no starting the challenge until the face is the correct distance away.

Issue #, if available:

Description of changes:

How did you test these changes?
(Please add a line here how the changes were tested)

Documentation update required?

  • No
  • Yes (Please include a PR link for the documentation update)

General Checklist

  • Added Unit Tests
  • Added Integration Tests
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)
  • Ensure commit message has the appropriate scope (e.g fix(liveness): message, fix(authenticator): message, fix(all): message)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@tylerjroach tylerjroach requested review from a team as code owners October 2, 2025 17:03
Copy link

codecov bot commented Oct 2, 2025

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 32.65%. Comparing base (0e9a121) to head (a2342d8).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #271   +/-   ##
=======================================
  Coverage   32.64%   32.65%           
=======================================
  Files         100      100           
  Lines        4622     4621    -1     
  Branches      587      587           
=======================================
  Hits         1509     1509           
  Misses       2956     2956           
+ Partials      157      156    -1     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tylerjroach tylerjroach merged commit b2edddd into main Oct 2, 2025
5 of 6 checks passed
@tylerjroach tylerjroach deleted the tjroach/prevent-challenge-restart branch October 2, 2025 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants