Skip to content

fix(liveness): Prevent challenge from restarting #271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 2, 2025
Merged

fix(liveness): Prevent challenge from restarting #271

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3b31b6f
Prevent challenge from restarting. Challenge shouldn't begin until fa…
tylerjroach Oct 2, 2025
a2342d8
Additional update and test correction
tylerjroach Oct 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions liveness/src/main/java/com/amplifyframework/ui/liveness/state/LivenessState.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -231,7 +231,7 @@ internal data class LivenessState(
}
}

if (readyForOval) {
if (readyForOval && initialFaceDistanceCheckPassed) {
if (initialStreamFace == null) {
val face = InitialStreamFace(faceRect, System.currentTimeMillis())
onCaptureReady()
Expand Down Expand Up @@ -311,7 +311,6 @@ internal data class LivenessState(
}

fun onStartViewComplete() {
livenessCheckState = LivenessCheckState.Running()
showingStartView = false
}
}
27 changes: 22 additions & 5 deletions liveness/src/test/java/com/amplifyframework/ui/liveness/state/LivenessStateTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,8 +152,8 @@ internal class LivenessStateTest {
}

@Test
fun `beginning state is running`() {
assertTrue(livenessState.livenessCheckState is LivenessCheckState.Running)
fun `beginning state is initial`() {
assertTrue(livenessState.livenessCheckState is LivenessCheckState.Initial)
}

@Test
Expand Down Expand Up @@ -263,9 +263,26 @@ internal class LivenessStateTest {
}

@Test
fun `challenge runs after retrieving session info`() {
val faceLivenessSession = mockk<FaceLivenessSession>(relaxed = true)
fun `challenge runs after retrieving session info and detected face far enough away`() {
val faceTargetChallenge = mockk<FaceTargetChallenge>(relaxed = true)
val challenges = listOf<FaceLivenessSessionChallenge>(faceTargetChallenge)
every { faceTargetChallenge.faceTargetMatching.faceDistanceThresholdMin } returns 1f
val faceLivenessSession = FaceLivenessSession(
challengeId = "12345",
challengeType = FaceLivenessChallengeType.FaceMovementAndLightChallenge,
challenges = challenges,
onVideoEvent = { },
onChallengeResponseEvent = { },
stopLivenessSession = { }
)
livenessState.onLivenessSessionReady(faceLivenessSession)

val faceRect = RectF(20f, 20f, 100f, 100f)
val leftEye = FaceDetector.Landmark(25f, 40f)
val rightEye = FaceDetector.Landmark(75f, 40f)
val mouth = FaceDetector.Landmark(40f, 80f)
livenessState.onFrameFaceUpdate(faceRect, leftEye, rightEye, mouth)

assertTrue(livenessState.livenessCheckState is LivenessCheckState.Running)
assertTrue(livenessState.readyForOval)
}
Expand Down Expand Up @@ -392,7 +409,7 @@ internal class LivenessStateTest {
val rightEye = FaceDetector.Landmark(75f, 40f)
val mouth = FaceDetector.Landmark(40f, 80f)
livenessState.onFrameFaceUpdate(faceRect, leftEye, rightEye, mouth)
assertTrue(livenessState.livenessCheckState is LivenessCheckState.Running)
assertTrue(livenessState.livenessCheckState is LivenessCheckState.Initial)
}

@Test
Expand Down