chore: Migrated Vite to Rollup, Removed Vite related dependencies #6423

yuhengshs · 2025-03-12T16:25:00Z

Description of changes

This PR serves the purpose of migrating from Vite to Rollup in vue package

Issue #, if available

Description of how you validated changes

Checklist

Have read the Pull Request Guidelines
PR description included
yarn test passes and tests are updated/added
PR title and commit messages follow conventional commit syntax
If this change should result in a version bump, changeset added (This can be done after creating the PR.) This does not apply to changes made to docs, e2e, examples, or other private packages.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

changeset-bot · 2025-03-12T16:25:04Z

⚠️ No Changeset found

Latest commit: 933afee

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

calebpollman

Thanks for handling this @yuhengshs! Have some questions on the configuration changes and there's some cleanup that can be addressed before merging. Curious how we are validating the compatibility of the new build artifacts against the existing artifacts?

packages/vue/rollup.config.mjs

packages/vue/jest.config.ts

packages/vue/package.json

packages/vue/rollup.config.mjs

…cessive unnecessary sutff

calebpollman · 2025-06-03T16:38:45Z

examples/vue/package.json

-    "vue": "^3.0.5",
+    "vue": "^3.5.14",
    "vue-router": "4"
  },
  "devDependencies": {
    "@types/node": "18.8.0",
-    "@vue/compiler-sfc": "^3.0.5",
+    "@vue/compiler-sfc": "^3.5.14",


Remove these changes, as a reviewer it makes me question whether the changes impact the build artifacts

calebpollman · 2025-06-03T16:38:57Z

examples/vue/src/main.ts

+import AmplifyUIVue from '@aws-amplify/ui-vue';
+import '@aws-amplify/ui-vue/styles.css';

-createApp(App).use(router).mount('#app');
+// Create app and register plugins
+const app = createApp(App);
+app.use(router);
+app.use(AmplifyUIVue);
+app.mount('#app');


Remove these changes, as a reviewer it makes me question whether the changes impact the build artifacts

calebpollman · 2025-06-03T16:40:29Z

packages/vue/src/components/index.ts

+// Export all primitive base components
+export { default as BaseInput } from './primitives/base-input.vue';
+export { default as BaseLabel } from './primitives/base-label.vue';
+export { default as BaseSelect } from './primitives/base-select.vue';
+export { default as BaseWrapper } from './primitives/base-wrapper.vue';
+export { default as BaseAlert } from './primitives/base-alert.vue';
+export { default as BaseBox } from './primitives/base-box.vue';
+export { default as BaseFieldSet } from './primitives/base-field-set.vue';
+export { default as BaseFooter } from './primitives/base-footer.vue';
+export { default as BaseForm } from './primitives/base-form.vue';
+export { default as BaseHeading } from './primitives/base-heading.vue';
+export { default as BaseSpacer } from './primitives/base-spacer.vue';
+export { default as BaseText } from './primitives/base-text.vue';
+export { default as BaseTwoTabs } from './primitives/base-two-tabs.vue';
+export { default as BaseTwoTabItem } from './primitives/base-two-tab-item.vue';


Are these new public exports?

calebpollman · 2025-06-03T16:41:09Z

packages/vue/src/index.ts

+    app.component('BaseInput', BaseInput);
+    app.component('BaseLabel', BaseLabel);
+    app.component('BaseSelect', BaseSelect);
+    app.component('BaseWrapper', BaseWrapper);
+    app.component('BaseAlert', BaseAlert);
+    app.component('BaseBox', BaseBox);
+    app.component('BaseFieldSet', BaseFieldSet);
+    app.component('BaseFooter', BaseFooter);
+    app.component('BaseForm', BaseForm);
+    app.component('BaseHeading', BaseHeading);
+    app.component('BaseSpacer', BaseSpacer);
+    app.component('BaseText', BaseText);
+    app.component('BaseTwoTabs', BaseTwoTabs);
+    app.component('BaseTwoTabItem', BaseTwoTabItem);


What changed that requires the registaration of these modules?

calebpollman · 2025-06-03T16:41:44Z

examples/vue/src/pages/ui/components/authenticator/sign-up-with-attributes/index.vue

+        :required="false"
+        :disabled="false"


Remove these changes, as a reviewer it makes me question whether the changes impact the build artifacts

yuhengshs added 2 commits March 10, 2025 15:33

chore: Migrated Vite to Rollup, Removed Vite related dependencies

6ab49a6

changed global-spec back to ./src

b206bc4

yuhengshs requested a review from a team as a code owner March 12, 2025 16:25

yuhengshs had a problem deploying to ci March 12, 2025 16:37 — with GitHub Actions Error

yuhengshs temporarily deployed to ci March 12, 2025 16:37 — with GitHub Actions Inactive

yuhengshs had a problem deploying to ci March 12, 2025 16:37 — with GitHub Actions Error

yuhengshs had a problem deploying to ci March 12, 2025 16:37 — with GitHub Actions Failure

calebpollman reviewed Mar 12, 2025

View reviewed changes

yuhengshs force-pushed the chore/migrate-vite-to-rollup branch 3 times, most recently from 07413ea to 3763460 Compare March 18, 2025 23:15

Aligned with already existed configs from other packages. Removed exc…

029097a

…cessive unnecessary sutff

yuhengshs force-pushed the chore/migrate-vite-to-rollup branch from 3763460 to 029097a Compare March 18, 2025 23:31

yuhengshs had a problem deploying to ci March 18, 2025 23:41 — with GitHub Actions Error

yuhengshs had a problem deploying to ci March 18, 2025 23:41 — with GitHub Actions Failure

fix Unable to resolve

cff5273

yuhengshs temporarily deployed to ci March 18, 2025 23:58 — with GitHub Actions Inactive

yuhengshs had a problem deploying to ci March 18, 2025 23:58 — with GitHub Actions Failure

yuhengshs added 2 commits March 18, 2025 17:38

Added role=textbox in base-input.vue

af871a8

Fix password control component and update base-input with dynamic role

a751e5d

yuhengshs temporarily deployed to ci March 19, 2025 01:09 — with GitHub Actions Inactive

yuhengshs had a problem deploying to ci March 19, 2025 01:09 — with GitHub Actions Error

update base-input.vue

0b5e3e1

removed excessive exports and corrected dependencies

6b2a8ad

yuhengshs force-pushed the chore/migrate-vite-to-rollup branch from 9e4236d to 6b2a8ad Compare May 22, 2025 10:29

resolved merge conflict

89d3db4

yuhengshs force-pushed the chore/migrate-vite-to-rollup branch from 15ff344 to 89d3db4 Compare May 22, 2025 11:02

updated dependencies

2b64ed6

yuhengshs force-pushed the chore/migrate-vite-to-rollup branch from 850860a to 2b64ed6 Compare May 22, 2025 11:33

yuhengshs and others added 2 commits May 22, 2025 04:35

Merge branch 'main' into chore/migrate-vite-to-rollup

8e831ff

update snapshot test

829e883

yuhengshs had a problem deploying to ci May 22, 2025 14:24 — with GitHub Actions Error

yuhengshs had a problem deploying to ci May 22, 2025 14:24 — with GitHub Actions Failure

yuhengshs temporarily deployed to ci May 22, 2025 14:24 — with GitHub Actions Inactive

yuhengshs temporarily deployed to ci May 23, 2025 03:08 — with GitHub Actions Inactive

solved dependencies issues

933afee

yuhengshs force-pushed the chore/migrate-vite-to-rollup branch from 293e1ff to 933afee Compare May 23, 2025 05:07

yuhengshs temporarily deployed to ci May 23, 2025 05:17 — with GitHub Actions Inactive

yuhengshs requested a review from calebpollman May 23, 2025 05:46

calebpollman reviewed Jun 3, 2025

View reviewed changes

chore: Migrated Vite to Rollup, Removed Vite related dependencies #6423

Are you sure you want to change the base?

chore: Migrated Vite to Rollup, Removed Vite related dependencies #6423

Uh oh!

Conversation

yuhengshs commented Mar 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description of changes

Issue #, if available

Description of how you validated changes

Checklist

Uh oh!

changeset-bot bot commented Mar 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

calebpollman left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

calebpollman Jun 3, 2025

Choose a reason for hiding this comment

Uh oh!

calebpollman Jun 3, 2025

Choose a reason for hiding this comment

Uh oh!

calebpollman Jun 3, 2025

Choose a reason for hiding this comment

Uh oh!

calebpollman Jun 3, 2025

Choose a reason for hiding this comment

Uh oh!

calebpollman Jun 3, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

yuhengshs commented Mar 12, 2025 •

edited

Loading

changeset-bot bot commented Mar 12, 2025 •

edited

Loading