Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT! If this is a documentation PR for a specific release, this PR must go the corresponding release branch (
release-X.XX.X). If it is an "out-of-band" doc update, the PR must go to themasterbranch.Required PR information
To expedite approvals and merges for releases, provide the following information (select the
...button to the right at the top of your PR message to edit it):Before you request approvals
Approvers
We require 3-4 approvers to merge for non-trivial content changes (where a "trivial" change is a typo/grammar fix or a minor update to the format syntax):
Make sure you get a commitment from these reviewers in advance! It's hard to get good quality doc reviews in order in the 11th hour of a release.
Note: For trivial changes, you only need @erickson-doug's approval. He will merge your content once he's confirmed the fixes on staging.
Doc review checklist
Engineering reviewer checklist
For PRs that include code or notebook examples
MANDATORY: PR must include test run output
Provide this information for the QA reviewer in order to expedite their review.
Test run output:
Specify the release version, instance size and type, OS type and test output.
For Training tutorials:
{Convergence graph for training tutorials}
{Performance metrics
average_throughput,latency_p50,latency_p99and MFU% if available}Make sure this PR contains correct classification terms (Alpha, Beta, and Stable).
If possible, provide your results or a link to them for the reviewer to check your work.
Code example/notebook content PR checklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.