feat(batch): use async local storage for batch processing #4700
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
batch
pull-request-size
bot
added
the
size/XXL
|
svozza
commented
Oct 29, 2025
| this.successMessages.length = 0; | ||
| this.failureMessages.length = 0; | ||
| this.errors.length = 0; | ||
| this.successMessages = []; |
There was a problem hiding this comment.
I've changed this because it seemed odd to be just setting the length to 0 rather than just resetting the variable as is done elsewhere.
sdangol
reviewed
Oct 30, 2025
| record, | ||
| new SqsFifoShortCircuitError() | ||
| ); | ||
| processedRecords.push(result); |
There was a problem hiding this comment.
Did we miss having this previously?
| record, | ||
| new SqsFifoShortCircuitError() | ||
| ); | ||
| processedRecords.push(result); |
There was a problem hiding this comment.
Same in here, was there a bug because of this?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds support for using an async context (specifically from the InvokeStore package) in the Batch utility. This allows users to process batches that are isolated specifically to the current lambda invocation, isolated from any other executions.
Changes
InvokeStoreto persist state across invocations.BatchProcessingStoreSqsFifoProcessorStoreBatchProcessingStoreclass: if we followed the pattern of replacing all in place mutation with specific methods that guard against mutating the underlying resources, this would entail far more changes to the code across the mutliple subclasses. Instead, I have chose to use getters and setters to proxy updates to the store to ensure the the amount of changes to the code are minimised.BatchProcessorandSqsFifoPartialProcessorclasses that use them.Issue number: closes #4676
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.