You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I'm seeing some transient issues on the end to end tests that I think are unrelated to this PR, but since I want to make sure these tests are green before merging I'd ask to please hold on with merging this PR until I have fixed them.
Hi @jaimellamasi, I checked out your changes and ran the updated E2E tests from #4909 on the branch and everything worked so we are good to go. Could you please rebase against main to resolve the merge conflict? It's just a package-lock.json issue so you should be able to fix it with npm install.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commonsThis item relates to the Commons UtilitydependenciesChanges that touch dependencies, e.g. Dependabot, etc.do-not-mergeThis item should not be mergedloggerThis item relates to the Logger Utilitysize/XLPRs between 500-999 LOC, often PRs that grown with feedbacktestsPRs that add or change tests
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pull-request-size
bot
added
the
size/XL
boring-cyborg
bot
added
commons
svozza
force-pushed
the
refactor/replace-lodash-merge-with-custom-deep-merge
branch
from
Summary
Changes
lodash.mergedependency from logger packagedeepMergeutility to commons packageIssue number: closes #4846
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.