Skip to content

Conversation

Eli1123
Copy link

@Eli1123 Eli1123 commented Aug 12, 2022

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

EricGrudzien
EricGrudzien approved these changes Dec 30, 2022
Copy link
Collaborator

@allamand allamand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you explain in a issue what this PR is for ?
Also you commited some specifics urls that should not be public

timeout: 5s
metadata:
type: cmd
cmd: "hey -c 10 -q 3 -z 1m -m GET http://af01d39d9c6fc48e3af813137371a563-990038456.us-east-2.elb.amazonaws.com" No newline at end of file
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whet this url is for ? don't seems you want to publish that on a public repo

kubernetes.io/ingress.class: "nginx"
spec:
rules:
- host: "http://af01d39d9c6fc48e3af813137371a563-990038456.us-east-2.elb.amazonaws.com"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same remark, here, should be var

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants