eventbridge-sns-lambda-terraform: Update runtime to nodejs22.x #2816
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kakakakakku
commented
Aug 14, 2025
| @@ -2,11 +2,7 @@ | |||
| * SPDX-License-Identifier: MIT-0 | |||
| */ | |||
|
|
|||
| const AWS = require('aws-sdk') | |||
| AWS.config.region = process.env.AWS_REGION | |||
| const sns = new AWS.SNS({apiVersion: '2012-11-05'}) | |||
There was a problem hiding this comment.
note: I removed this because it wasn’t used.
| @@ -6,7 +6,7 @@ terraform { | |||
| required_providers { | |||
| aws = { | |||
| source = "hashicorp/aws" | |||
| version = "~> 3.27" | |||
| version = "~> 5.0" | |||
There was a problem hiding this comment.
note: Older version does not support Node.js 22 runtime. So I updated the version to v5.
| resource "aws_iam_role_policy_attachment" "lambda_basic_execution" { | ||
| role = aws_iam_role.lambda_iam_role.name | ||
| policy_arn = data.aws_iam_policy.lambda_basic_execution_role_policy.arn | ||
| } |
There was a problem hiding this comment.
note: The managed_policy_arns argument is already deprecated. I update code correctly😀 See document below.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
N/A
Description of changes:
Hi😀 Thanks for the useful patterns!
To prevent future deployment issues, I updated the Lambda Node.js runtime version to
nodejs22.x.While testing
eventbridge-sns-lambda-terraform, I noticed that the Lambda runtime versionnodejs16.xwas deprecated. Although it's still deployable at the moment, it will not be allowed after October 1, 2025.https://docs.aws.amazon.com/lambda/latest/dg/lambda-runtimes.html
Check
terraform applycompleted successfully and works good.$ aws events put-events --entries file://event.json --region us-east-1 { "FailedEntryCount": 0, "Entries": [ { "EventId": "79beda9e-c873-ace9-1fa9-2d315bab2801" } ] }Thank you😀
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.