Adding default error_mode to jmx drop config yaml to fix unmarshalling issue #1790
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Paramadon
changed the title
Paramadon
force-pushed
the
paramadon/fixingJmsDropTranslator
branch
from
b7b8fbf to
d9776b1
Compare
phugay
approved these changes
Jul 23, 2025
sky333999
reviewed
Jul 23, 2025
| metric_statements: | ||
| - context: resource | ||
| error_mode: "" | ||
| error_mode: propagate |
There was a problem hiding this comment.
What about ones such as
?…ramadon/fixingJmsDropTranslator
|
This PR was marked stale due to lack of activity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the issue
Currently there the translator for jmx drop config yaml does not have error_mode set which means that it will be set to "" by default which can cause unmarshalling issues in the agent.
Description of changes
Adding error_mode: propagate to jmx drop config yaml to make sure there are no unmarshaling issues. We have the same behavior in the metrics decorator translator code.