-
Notifications
You must be signed in to change notification settings - Fork 69
feat: add plugin for DSQL auth tokens #1477
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
2bd92c9
to
a53fa62
Compare
Latest change is a simple rebase to update the branch with the latest |
wrapper/src/test/java/software/amazon/jdbc/plugin/iam/DsqlIamConnectionPluginTest.java
Outdated
Show resolved
Hide resolved
a53fa62
to
e07c358
Compare
Update to e07c358 addresses a few issues:
|
e07c358
to
a7378b3
Compare
Update to a7378b3 changes the |
wrapper/src/main/java/software/amazon/jdbc/plugin/iam/DsqlTokenUtility.java
Outdated
Show resolved
Hide resolved
a7378b3
to
bb1f7c5
Compare
Update to bb1f7c5 uses a static mock instead of a test-only constructor. |
bb1f7c5
to
a1c6593
Compare
Update to a1c6593 fixes some formatting issues which were flagged by the GitHub actions. |
a1c6593
to
7c9c3fc
Compare
Update to 7c9c3fc removes a unit test dependency on the system AWS credentials provider. |
wrapper/src/main/java/software/amazon/jdbc/plugin/iam/DsqlIamConnectionPluginFactory.java
Outdated
Show resolved
Hide resolved
wrapper/src/main/java/software/amazon/jdbc/plugin/iam/DsqlTokenUtility.java
Show resolved
Hide resolved
7c9c3fc
to
3e6bd2a
Compare
Update to 3e6bd2a addresses a comment by adding a user-facing warning message if the DSQL SDK dependency is missing. |
3e6bd2a
to
4dfd2a0
Compare
Update to 4dfd2a0 addresses an offline comment from @deepakscomk about a possible error for subsequent calls to |
4dfd2a0
to
8c3d0a7
Compare
Update to 8c3d0a7 performs a rebase to pull in a fix from |
wrapper/src/main/java/software/amazon/jdbc/plugin/iam/IamAuthConnectionPlugin.java
Outdated
Show resolved
Hide resolved
8c3d0a7
to
b879640
Compare
Summary
Adds a new
dsql
plugin which creates authentication tokens for Amazon Aurora DSQL.Description
Changes include the added
dsql
plugin, which is an extension of the existingIamAuthConnectionPlugin
with a custom token generator. Both new files are unit tested.A new dependency was added which customers will also need if using the plugin. Requirements will be documented in an upcoming change.
Credit to @karenc-bq for the initial plugin implementation.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.