feat: add support for blue/green deployments #911
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karenc-bq
reviewed
Jul 10, 2025
aws_advanced_python_wrapper/resources/aws_advanced_python_wrapper_messages.properties
Outdated
Show resolved
Hide resolved
karenc-bq
approved these changes
Jul 17, 2025
| logger.debug( | ||
| Messages.get_formatted( | ||
| "SuspendConnectRouting.SwitchoverCompleteContinueWithConnect", | ||
| (time.time() - start_time_sec) // 1000)) |
There was a problem hiding this comment.
Suggested change
| (time.time() - start_time_sec) // 1000)) | |
| (time.time() - start_time_sec) * 1000)) |
There was a problem hiding this comment.
Should we track the time using ms or ns instead of seconds for more detailed time reporting?
There was a problem hiding this comment.
time.time() returns a floating point that includes fractions of a second, for example if I run time.time() on my machine I get 1752773235.3210173, so I believe we will still get ms precision
karenc-bq
reviewed
Jul 17, 2025
| switchover_completed = (not self._rollback and self._summary_status.phase == BlueGreenPhase.COMPLETED) or \ | ||
| (self._rollback and self._summary_status.phase == BlueGreenPhase.CREATED) | ||
| has_active_switchover_phases = \ | ||
| any(phase_info.phase is not None and phase_info.phase.is_active_switchover_completed |
There was a problem hiding this comment.
Suggested change
| any(phase_info.phase is not None and phase_info.phase.is_active_switchover_completed | |
| any(phase_info.phase is not None and phase_info.phase.is_switchover_active_or_completed |
There was a problem hiding this comment.
The log switchover final summary output's formatting looks off, would you be able to verify it?
----------------------------------------------------------------------------------
timestamp time offset (ms) event----------------------------------------------------------------------------------
>28s ms
----------------------------------------------------------------------------------
karenc-bq
reviewed
Jul 18, 2025
|
|
||
| def _update_dns_flags(self, bg_role: BlueGreenRole, interim_status: BlueGreenInterimStatus): | ||
| if bg_role == BlueGreenRole.SOURCE and not self._blue_dns_update_completed and interim_status.all_start_topology_ip_changed: | ||
| logger.debug("bgd.blueDnsCompleted", self._bg_id) |
There was a problem hiding this comment.
Suggested change
| logger.debug("bgd.blueDnsCompleted", self._bg_id) | |
| logger.debug("BlueGreenStatusProvider.BlueDnsCompleted", self._bg_id) |
karenc-bq
reviewed
Jul 18, 2025
| self._store_event_phase_time("Blue DNS updated") | ||
|
|
||
| if bg_role == BlueGreenRole.TARGET and not self._green_dns_removed and interim_status.all_start_topology_endpoints_removed: | ||
| logger.debug("bgd.greenDnsRemoved", self._bg_id) |
There was a problem hiding this comment.
Suggested change
| logger.debug("bgd.greenDnsRemoved", self._bg_id) | |
| logger.debug("BlueGreenStatusProvider.GreenDnsRemoved", self._bg_id) |
karenc-bq
reviewed
Jul 18, 2025
| self._store_event_phase_time("Green DNS removed") | ||
|
|
||
| if bg_role == BlueGreenRole.TARGET and not self._green_topology_changed and interim_status.all_topology_changed: | ||
| logger.debug("bgd.greenTopologyChanged", self._bg_id) |
There was a problem hiding this comment.
Suggested change
| logger.debug("bgd.greenTopologyChanged", self._bg_id) | |
| logger.debug("BlueGreenStatusProvider.GreenTopologyChanged", self._bg_id) |
karenc-bq
reviewed
Jul 18, 2025
| self._summary_status = self._get_status_of_completed() | ||
|
|
||
| else: | ||
| raise ValueError(Messages.get_formatted("bgd.unknownPhase", self._bg_id, self._latest_phase)) |
There was a problem hiding this comment.
Suggested change
| raise ValueError(Messages.get_formatted("bgd.unknownPhase", self._bg_id, self._latest_phase)) | |
| raise ValueError(Messages.get_formatted("BlueGreenStatusProvider.UnknownPhase", self._bg_id, self._latest_phase)) |
… inner value of the ValueContainer
karenc-bq
reviewed
Jul 19, 2025
| execute_func: Callable, | ||
| *args: Any, | ||
| **kwargs: Any) -> ValueContainer[Any]: | ||
| logger.debug("SuspendExecuteRouting.InProgressSuspendMethod") |
There was a problem hiding this comment.
Suggested change
| logger.debug("SuspendExecuteRouting.InProgressSuspendMethod") | |
| logger.debug("SuspendExecuteRouting.InProgressSuspendMethod", method_name) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds support for Blue/Green Deployments for the following DB types:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.