fix: Flakey integration tests in read write splitting integration tests #961
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JuanLeee
force-pushed
the
integration/flakey-tests
branch
from
e487b2f to
4aeaf21
Compare
aaron-congo
approved these changes
Sep 3, 2025
JuanLeee
force-pushed
the
integration/flakey-tests
branch
from
4aeaf21 to
f0cc93c
Compare
sophia-bq
approved these changes
Sep 4, 2025
karenc-bq
reviewed
Sep 4, 2025
| yield | ||
| ConnectionProviderManager.release_resources() | ||
| ConnectionProviderManager.reset_provider() | ||
| gc.collect() |
There was a problem hiding this comment.
curious why is this required?
There was a problem hiding this comment.
Not required but ensures any objects like connections are deleted. There were issues with the integration tests not being about to make the initial connection and could be caused by existing resources not fully cleaned up.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating integration tests for read write splitting with: